Fix: Properly format switch expressions #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhany97
commented
Apr 5, 2024
| @@ -63,6 +63,7 @@ void reformat_a_subpath_of_a_git_directory_for_only_changed_lines() throws IOExc | |||
| runCommandInRepo("git", "init"); | |||
| runCommandInRepo("git", "config", "user.name", "Test User"); | |||
| runCommandInRepo("git", "config", "user.email", "[email protected]"); | |||
| runCommandInRepo("git", "config", "commit.gpgsign", "false"); | |||
There was a problem hiding this comment.
Drive-by improvement: Didn't see it as necessary to sign the commits made by the test
johnhany97
commented
Apr 5, 2024
Comment on lines
+52
to
+57
| int x = | ||
| switch (y) { | ||
| case 1 -> 1; | ||
| case 2 -> throw new IllegalArgumentException(); | ||
| default -> throw new IllegalStateException(); | ||
| }; |
There was a problem hiding this comment.
Would like to fix this in the future FWIW to instead be:
int x = switch (y) {
case 1 -> 1;
case 2 -> throw new IllegalArgumentException();
default -> throw new IllegalStateException();
};But that requires more complicated changes to happen to the visitAssignment method which should be left to a separate PR
|
Released 2.42.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Fixes #1025 where before this change, we'd format switch expressions used in an assignment to yield the following:
After this PR
==COMMIT_MSG==
Properly format switch expressions
==COMMIT_MSG==
and now we generate this:
Possible downsides?